search

vmware / photon-os-installer

Photon OS Installer
Other
12 stars 18 forks source link

Added device number of virtio block device (253) in the list of poten… #25

Closed sbskas closed 7 months ago

sbskas commented 7 months ago

Add major block number of virtio block devices to allow installer to select virtio devices for installation.

vmwclabot commented 7 months ago

@sbskas, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 7 months ago

@sbskas, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

oliverkurth commented 7 months ago

Thank you - however, we have a more comprehensive fix here already: https://github.com/vmware/photon-os-installer/commit/63bd1e66e14a99a539b48d4db147cfa2b2b2902a . It's in the poi-container branch,

I am not sure why it hasn't made it to the master branch, I will check.

sbskas commented 7 months ago

The excluded list crossed my mind, but this one was more straightforward. Do you want me to close the PR ?

oliverkurth commented 7 months ago

The excluded list crossed my mind, but this one was more straightforward. Do you want me to close the PR ?

Yes, we are going to merge https://github.com/vmware/photon-os-installer/commit/63bd1e66e14a99a539b48d4db147cfa2b2b2902a , together with other changes.

vmwclabot commented 6 months ago

@sbskas, VMware has approved your signed contributor license agreement.