search

vmware / photon-os-installer

Photon OS Installer
Other
12 stars 18 forks source link

Add version to installer with git commit hash info #8

Closed sshedi closed 3 years ago

sshedi commented 3 years ago

This info will help to check for installer updates in Photon builder.

Signed-off-by: Shreenidhi Shedi sshedi@vmware.com

sshedi commented 3 years ago

@gpiyush-dev We can do something like this in builder:

if hasattr(installer.__version__):
    check commit hash - if they differ pull (compare against installer.__version__ & git ls-remote $URL HEAD)
else:
   pull from git right away

For doing pip3 install, we need to use:

sudo -u $(who | sed 's/ .*//') pip3 install <installer-url>

Or we can install as sudo, np. This is a trusted pkg

sshedi commented 3 years ago

Using internal gerrit for this. Hence, closing it here.