vmware / photon

Minimal Linux container host
https://vmware.github.io/photon
Other
3.04k stars 698 forks source link

Issues building linux.spec #1044

Open randomvariable opened 4 years ago

randomvariable commented 4 years ago

Testing patches on the Linux kernel, have noticed a number of issues:

Makes it difficult to get a clean build of the RPM.

srivatsabhat commented 4 years ago

Can you share the steps that you are using to build the kernel rpm? What is the photon branch on which you are trying this out?

Do you face these issues if your run make linux after cloning the photon repo and checking out say, the 3.0 branch?

randomvariable commented 4 years ago

I had the 3.0 branch checked out, and them and building in Docker as per https://github.com/randomvariable/photonbuild

Attempting to do rpmbuild --undefine=_disable_source_fetch -ba fails on downloading the checksum generator and there's no URL reference for the xr_usb_serial...file

I eventually downloaded the source RPM as per the Dockerfile in the above repo to get the remaining xr_usb_serial_common_lnx-3.6-and-newer-pak.tar.xz files.

Then there were missing dependencies, which I've addressed in https://github.com/vmware/photon/pull/1048/files#diff-0c9313a1a4c2b33bf0d6a4f5ee4b953eR218-R224 as I was only looking at linux.spec

Finally, the config file failed make mrproper and needed https://github.com/vmware/photon/pull/1048/files#diff-4219a0087de8c6c454bbe989b2d9a02a to work.

srivatsabhat commented 4 years ago

We already have a script that @YustasSwamp wrote to build RPMs from package sources using Photon, while running the script outside the photon source repo.

https://vmware.github.io/photon/assets/files/html/3.0/photon_installation/build-package-kernel-using-script.html https://github.com/vmware/photon/blob/master/tools/scripts/build_spec.sh

Can you give this a try?

randomvariable commented 4 years ago

Did try it the other week, but I didn't have much success. I'll try a clean build again in a bit and post the errors.