vmware / photonos-netmgr

network management on PhotonOS
Other
6 stars 10 forks source link

netmgr discards additional domain names if they are a substring of previous arguments #2

Open suezzelur opened 6 years ago

suezzelur commented 6 years ago

netmgr --version

netmgmt: 1.1.0

netmgr dns_domains --set --domains abc.xyz.com,xyz.com


results in Domains containing only abc.xyz.com in /etc/systemd/resolved.conf: Domains=abc.xyz.com

And /etc/resolve.conf: search abc.xyz.com

It seems nm_space_delimited_string_append() is skipping elements if they are already part of the resulting space delimited string:

if (strstr(pszNewString, ppszStrings[i]) == NULL) { strcat(pszNewString, ppszStrings[i]); }

Note that when getting this list from DHCP doesn't work either.

However, if the /etc/systemd/resolved.conf is manually configured with Domains=abc.xyz.com xyz.com and /etc/resolv.conf contains search abc.xyz.com xyz.com

Then I'm able to ping machines in xyz.com