vmware / photonos-netmgr

network management on PhotonOS
Other
6 stars 10 forks source link

Netmgr enhancements #5

Open suezzelur opened 6 years ago

suezzelur commented 6 years ago

Netmgr does not report the correct ip address if the ip address is statically overridden using ifconfig.

Fix netmgr help text.

1) It should specify the model: netmgr <--get | --set | --add | --del>

2) Fix "ifame" typo in link_info usage: root@footest [ ~ ]# netmgr link_info Usage: link_info --get --interface

3) Add brackets to --mode in Help text. <dhcp|static|none> ip4_address --set --interface --mode dhcp|static|none

4) Create separate entries in help text for --add|--del. ip6_address --get --interface ip6_address --add --interface --addrlist <IPv6Addr1/prefix,IPv6Addr2/prefix,...> ip6_address --del --interface --addrlist <IPv6Addr1/prefix,IPv6Addr2/prefix,...> ip6_address --set --interface --dhcp <1|0> --autoconf <1|0>

5) Add brackets to --mode in Help text. <dhcp|static>. Add "none" as an option? Create separate entries in help text for --add|–del. dns_servers --get dns_servers --set --mode dhcp|static --servers <server1,server2,...>

6) Help text contains example. Replace with ""? Get or set the DHCP DUID, optionally per interface. dhcp_duid --get dhcp_duid --set --duid '00:01:00:00:11:22:33:44:55:66:77:88'

7) Make timeout optional (default 0) in wait_for_link and wait_for_ip commands.

8)Rename DNS_MODE_INVALID to DNS_MODE_UNKNOWN.

9)Fix CLI help text for DNS domains --add that shows multiple domains instead of just one. root@footest [ /etc/systemd/network ]# netmgr dns_domains Usage: dns_domains --get dns_domains --set --domains <domain1,domain2,...> dns_domains --add --domains <domain1,domain2,..> dns_domains --del --domains