vmware / powershell-module-for-vmware-cloud-foundation-power-management

PowerShell Module for VMware Cloud Foundation Power Management
https://vmware.github.io/powershell-module-for-vmware-cloud-foundation-power-management/
BSD 2-Clause "Simplified" License
10 stars 8 forks source link

Passwords should be entered with console "echo" #55

Closed tenthirtyam closed 11 months ago

tenthirtyam commented 1 year ago

Code of Conduct

Description

Passwords for connecting to different components are shown when prompted.

Use Case(s)

Password prompts should hide the string that is entered. For example, -AsSecureString as one possible solution.

Potential Configuration

We should enhance this:

  1. in the scripts itself (when the password is not provided as parameter).
  2. In the module - if we run some function from the module without parameters the user will be asked for input parameters, one of those parameters will be a password prompt.

Basically, in all places that we are asking for password as input parameter, these should be masked.

References

No response

github-actions[bot] commented 1 year ago

'Marking this issue as stale due to inactivity. This helps us focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!'

github-actions[bot] commented 11 months ago

'Marking this issue as stale due to inactivity. This helps us focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!'

tenthirtyam commented 11 months ago

Resolved in https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-power-management/pull/73.

github-actions[bot] commented 10 months ago

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.