vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
680 stars 57 forks source link

Simplify output handling in unit tests #494

Closed rosenhouse closed 1 year ago

rosenhouse commented 1 year ago

Fixes #288


Here's a side-by-side comparison, running in quiet mode (default) on the left, and with VERBOSE=1 on the right. image

and here's what it looks like when a test fails and you haven't set VERBOSE yet: image

netlify[bot] commented 1 year ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit 5d3e22407871dc98cb705e78a03af5110ecf0211
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/638faf8d2fd2270008975134
rosenhouse commented 1 year ago

@gapisback Thanks for the review. I've tried to improve the "new test author experience" part by updating splinter_test as much as was practical in a short-time, and leaving a note up top to caution against following patterns there. And then there's at least a clearer distinction between "unit" versus "functional".

And yes, let's merge this as-is, and we'll defer the flag thing to later.