vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
685 stars 57 forks source link

Document cache.h interfaces based on clockcache comments. #502

Closed jonhnet closed 1 year ago

jonhnet commented 1 year ago

I tried to document all the public methods on the cache.h polymorphic interface. Please see XXXs for places where I don't even have a guess. But also please check that the other text I wrote is actually correct.

netlify[bot] commented 1 year ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit c3146e60dc7f38d8052859d3d75981b3fd0c17cf
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/63b7c1f3b17d6b000928b187
jonhnet commented 1 year ago

@aconway: thanks for all the clarifications. All of these comments make and pass the tests. :v) Please take another peek.

jonhnet commented 1 year ago

@ajhconway gentle ping on this collection of comments. Thanks!