Closed gapisback closed 1 year ago
Name | Link |
---|---|
Latest commit | c46fff490a932ab6c1e06199f9950fb7775f554e |
Latest deploy log | https://app.netlify.com/sites/splinterdb/deploys/6411127f38f0f4000896be01 |
Discussed in the weekly PR meeting with @rtjohnso and @ajhconway .
The overall ideas that this PR, and its associated PR #537, were bringing-in, that is of looking at page / extent addresses as page number, extent ID, was not considered very useful. There was no conviction that adding unit-tests to exercise, say, the mini-allocator, to demonstrate how we walk through individual pages in an extent wasn't found to be too useful to merit integrating these changes to /main
.
Withdrawn.
This commit does some minor cleanup of the mini-allocator module. Some interfaces are slightly changed to streamline init / deinit interfaces. A new unit-test is added to exercise core interfaces of this page allocation system, and to test the print methods for keyed and unkeyed page allocation schemes.
No major code / logic changes. Introduced a new unit-test to exercise interfaces in
mini_allocator.c
along with additions of minor interfaces to manipulate page / extent addresses / validity etc. Some of the changes to streamlineinit
,deinit
calls will need some discussion during review. I've done my best effort, but think there is still room for improvement in this rework.