search

vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
684 stars 57 forks source link

Fixups to enable building this branch with clang #542

Closed rosenhouse closed 1 year ago

rosenhouse commented 1 year ago

Note this is a PR against your pg-splinterdb-shmem-integn-1 branch.

My editor uses clang for various IDE-like things. It's nice to have this branch buildable with clang.

netlify[bot] commented 1 year ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit c9355d6886171a6dce66031d5cef25917a77fbea
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/63e2a66646ff70000878af46
rosenhouse commented 1 year ago

Turns out removing the static broke the GCC build. So I undid that and fixed it a different way: https://github.com/vmware/splinterdb/commit/b9ea7ef29acdd0d5ce6c34211bfde3d14adb7093

Pushed that fix directly to the branch since it was so small.