netlify[bot]
commented
1 year ago Deploy Preview for splinterdb canceled.
| Name | Link |
|---|---|
| Latest commit | 9d182b42c3959a8b48fe05ccae933cc173ae98cf |
| Latest deploy log | https://app.netlify.com/sites/splinterdb/deploys/641a021ed381790008bf6c3c |
gapisback
This commit brings in basic support to create a shared memory segment and to redirect all memory allocation primitives to shared memory. Currently, we only support a simplistic memory mgmt; i.e. only-allocs, and no frees. With shared segments of 1-2 GiB we can run many functional and unit tests.
Some cavaets and fixes implemented to get some tests to run cleanly:
o Redirect large allocations to use malloc(), and not the shmem allocation.
We currently do not support free() for shared memory based allocation. Some sub-systems that allocate and free large chunks repeatedly use up too much shared memory, causing tests to fail .
This commit fixes that issue by re-directing following clients to fall-back to using regular malloc() / free() interfaces:
btree_pack_req_deinit()
With these changes, unit-test splinter_test now succeeds using shared memory:
sdb-fdb-build:[10] $ build/debug/bin/unit/splinter_test Running 1 CTests, suite name 'splinter', test case 'all'. TEST 1/3 splinter:test_inserts [OK] TEST 2/3 splinter:test_lookups [OK] TEST 3/3 splinter:test_splinter_print_diags [OK] RESULTS: 3 tests (3 ok, 0 failed, 0 skipped) ran in 1136485 ms
o Rework existing tests to support --use-shmem arg to run w/ shared segment.
Apply --use-shmem as the very 1st arg for different tests so that they can now leverage shared memory support. Following tests are / should be working with this fix:
With this argument, splinterdb_create_or_open() will now create a heap, i.e., allocate shared segment, if the calling test has not already done so.
NOTE: unit/btree_test still goes through shm-free code due to the use of scratch_buffer space in this test masquerading as heap-id. Investigate and resolve.
o Fix bugs & refactoring to enable unit stress-tests.
Minor rearrangement of code and fixing bugs. This commit now enables running btree_test and splinterdb_stress_test unit-tests with --use-shmem option.
o Enhances memory alloc/free diags to print name of object.
To better understand for which object memory allocation or free is occurring, this commit makes minor changes to caller-macros that allocate / free memory to also print object's name using STRINGIFY() on the parameter 'v'.
o Rework unit-testing, main.c, Makefile to support --use-shmem
Change test.sh also to run unit-tests with --use-shmem
Fix build failures, shfmt issues and chmod +x test.sh issues.
Fix chmod perms to +x