vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
680 stars 57 forks source link

(#554) Fixes to get couple of tests running cleanly in ASAN-builds #555

Closed gapisback closed 1 year ago

gapisback commented 1 year ago

This commit fixes minor errors in 2 tests (io_apis_test, filter_test) to get them running cleanly in ASAN-builds.

netlify[bot] commented 1 year ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit 4dc37ff60854699ce38a56494b91b7b45e962f47
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/641b7399d4e35900087d60be
gapisback commented 1 year ago

With these two fixes, my slow re-run of test.sh passes clean in ASAN build-mode. (MSAN build-mode tests are still running.)

FILE: ~/tmp/test.main.asan.slow.out

638 Wed Mar 22 12:26:30 PDT 2023 **** SplinterDB Test Suite Execution Times ****
639
640 Fast unit tests                                                       :  124s [  0h  2m  4s ]
641 Splinter inserts test                                                 :  249s [  0h  4m  9s ]
642 Splinter lookups test                                                 :  177s [  0h  2m 57s ]
643 Splinter print diagnostics test                                       :  254s [  0h  4m 14s ]
644 Functionality test, key size=8 bytes                                  :   38s [  0h  0m 38s ]
645 Functionality test, with default key size                             :   36s [  0h  0m 36s ]
646 Functionality test, default key size, with background threads         :   35s [  0h  0m 35s ]
647 Functionality test, key size=maximum (102 bytes)                      :   42s [  0h  0m 42s ]
648 Very quick Performance test                                           :    5s [  0h  0m  5s ]
649 Quick Performance test with bg-threads                                :    5s [  0h  0m  5s ]
650 Performance test                                                      :  321s [  0h  5m 21s ]
651 BTree test, key size=8 bytes                                          : 1173s [  0h 19m 33s ]
652 BTree test, with default key size                                     :  981s [  0h 16m 21s ]
653 BTree test, key size=100 bytes                                        :  647s [  0h 10m 47s ]
654 BTree Perf test                                                       :    0s [  0h  0m  0s ]
655 Cache test                                                            :   11s [  0h  0m 11s ]
656 Log test                                                              :    1s [  0h  0m  1s ]
657 Filter test                                                           :   11s [  0h  0m 11s ]
658 All Tests                                                             : 4397s [  1h 13m 17s ]
gapisback commented 1 year ago

Slow running tests from test.sh in MSAN build-mode are also running clean now:

File: ~/tmp/test.rel-msan.slow.out

637 ALL PASSED
638 Wed Mar 22 13:46:20 PDT 2023 **** SplinterDB Test Suite Execution Times ****
639
640 Fast unit tests                                                       :   66s [  0h  1m  6s ]
641 Splinter inserts test                                                 :  105s [  0h  1m 45s ]
642 Splinter lookups test                                                 :   96s [  0h  1m 36s ]
643 Splinter print diagnostics test                                       :  107s [  0h  1m 47s ]
644 Functionality test, key size=8 bytes                                  :   14s [  0h  0m 14s ]
645 Functionality test, with default key size                             :   14s [  0h  0m 14s ]
646 Functionality test, default key size, with background threads         :   14s [  0h  0m 14s ]
647 Functionality test, key size=maximum (102 bytes)                      :   16s [  0h  0m 16s ]
648 Very quick Performance test                                           :    2s [  0h  0m  2s ]
649 Quick Performance test with bg-threads                                :    1s [  0h  0m  1s ]
650 Performance test                                                      :  162s [  0h  2m 42s ]
651 BTree test, key size=8 bytes                                          :  401s [  0h  6m 41s ]
652 BTree test, with default key size                                     :  353s [  0h  5m 53s ]
653 BTree test, key size=100 bytes                                        :  206s [  0h  3m 26s ]
654 BTree Perf test                                                       :    0s [  0h  0m  0s ]
655 Cache test                                                            :    9s [  0h  0m  9s ]
656 Log test                                                              :    1s [  0h  0m  1s ]
657 Filter test                                                           :    5s [  0h  0m  5s ]
658 All Tests                                                             : 1694s [  0h 28m 14s ]
659
660 Wed Mar 22 14:14:34 PDT 2023 End SplinterDB Test Suite Execution.