vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
673 stars 56 forks source link

Trunk Assertion Fix and Simplification #590

Closed etwest closed 1 year ago

etwest commented 1 year ago

This pull request does:

  1. Fixes an assertion bug in trunk_replace_routing_filter. Previously we asserted that if we compacted down to an empty bundle then the filter must also be NULL. However, this is not necessarily the case. Changed the assertion to assert that if the compacted bundle and the filter are empty then the filter is NULL.
  2. Simplifies the trunk_range_iterator struct by the removal of local_max_key. local_max_key is now a temporary variable in trunk_range_iterator_init.
netlify[bot] commented 1 year ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit b9bf21696359ebf29fccd6dbfd2013bb535074f4
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/64b05cf44ffae8000865dd13