vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
673 stars 56 forks source link

Remove #include <unistd.h> from various files that use getpid(). Instead provide platform'ized version of getpid() #599

Closed gapisback closed 5 months ago

gapisback commented 8 months ago

This cleanup comment comes out of the review cycle for PR #568 . See this comment from @rtjohnso


I think all the other instances of #include were introduced by you in the previous PR for multi-process support. We need to clean them all out by platformizing getpid.


Solution that will be attempted:

This seems like it will work ... try it out.

gapisback commented 8 months ago

@rtjohnso -- This is the clean-up issue you raised. Let me know if the proposed solution is acceptable to you. I'll get to this after part-3 lands.