This cleanup comment comes out of the review cycle for PR #568 . See this comment from @rtjohnso
I think all the other instances of #include were introduced by you in the previous PR for multi-process support. We need to clean them all out by platformizing getpid.
Solution that will be attempted:
Add platform_getpid() in platform_linux/platform_inline.h, defined as OS getpid()
Use platform_getpid() everywhere getpid() is being used now.
This cleanup comment comes out of the review cycle for PR #568 . See this comment from @rtjohnso
I think all the other instances of #include were introduced by you in the previous PR for multi-process support. We need to clean them all out by platformizing getpid.
Solution that will be attempted:
platform_getpid()
inplatform_linux/platform_inline.h
, defined as OSgetpid()
platform_getpid()
everywheregetpid()
is being used now.#include <unistd.h>
in above.h
This seems like it will work ... try it out.