vmware / splinterdb

High Performance Embedded Key-Value Store
https://splinterdb.org
Apache License 2.0
682 stars 57 forks source link

shmem.c: Rename variables relating to large-fragment handling. #609

Closed gapisback closed 8 months ago

gapisback commented 8 months ago

Upcoming PR #569 is bringing-in support for handling small fragments. This commit renames existing variables, field names and a few function names that deal with large-fragment support to consistently use 'large' in the name. This clears the way in the namespace for upcoming small-fragment changes.

Some examples:

... No other code-/logic-changes are done with this commit.

netlify[bot] commented 8 months ago

Deploy Preview for splinterdb canceled.

Name Link
Latest commit 551d7ecf018b9447f8446b347d65354bf5adf384
Latest deploy log https://app.netlify.com/sites/splinterdb/deploys/65b116f302c52200080ffba4
gapisback commented 8 months ago

@rtjohnso -- Rob I am assigning this review to you optimistically expecting that the CI-jobs that just took off will succeed.

It's just a code-cleanup variable renaming PR, so no logic should have changed.

Can you give this a quick look so I can merge this and apply the next peel-off code item in queue tonight?

Thanks.

gapisback commented 8 months ago

@rtjohnso, The concept of small / large fragments is contained within the shared memory manager. Rest of the consumer code only knows about fragments, given a memfrag handle.

(I think that's how all this is playing out, and will watch out for this issue while finalizing changes for upcoming PR #569 .)