Closed ksamoray closed 3 months ago
/test-all
/test-all
/test-all
/test-all
/test-all
I didn't see any update in setUpgradeRunOutput
function (sorry if I missed it), but looks like custom group needs to be updated with its new attributes
I didn't see any update in
setUpgradeRunOutput
function (sorry if I missed it), but looks like custom group needs to be updated with its new attributes
Yeah I missed this. Although as we do not support the state existence, that's a bit meaningless for now.
I didn't see any update in
setUpgradeRunOutput
function (sorry if I missed it), but looks like custom group needs to be updated with its new attributes
But this is only the status type - which doesn't have the extra group attributes. So I'm not sure that a change is required here.
I didn't see any update in
setUpgradeRunOutput
function (sorry if I missed it), but looks like custom group needs to be updated with its new attributesYeah I missed this. Although as we do not support the state existence, that's a bit meaningless for now.
I think that although we ask to remove state post-upgrade, terraform plan
should not produce non-empty diff after upgrade. is this true today?
LGTM, except for two doubts:
terraform plan
show non-empty diff? Terraform doesn't show an empty diff, also without these changes as far as I understand (there are dependencies on computed groups within the upgrade process - I think that this is the reason?). As for group deletion: it's possible to check the groups for empty groups (with no upgrade units) which do not match the "predefined group pattern" (either have the id of a compute collection, or that hardcoded name which NSX uses for non-clustered hosts). These can be deleted I guess. Is that what you had in mind?
Terraform doesn't show an empty diff, also without these changes as far as I understand (there are dependencies on computed groups within the upgrade process - I think that this is the reason?). As for group deletion: it's possible to check the groups for empty groups (with no upgrade units) which do not match the "predefined group pattern" (either have the id of a compute collection, or that hardcoded name which NSX uses for non-clustered hosts). These can be deleted I guess. Is that what you had in mind?
I would suggest to rely on GetChange
routing to check if groups are explicitly deleted + deleting groups that we know are recreated as a result of update.
/test-all
Add the logic to create and update custom host groups while running the upgrade process.