vmware / terraform-provider-nsxt

Terraform VMware NSX-T provider
https://www.terraform.io/docs/providers/nsxt/
Other
123 stars 80 forks source link

VPC E-W security policy resource #1217

Closed ksamoray closed 1 month ago

ksamoray commented 2 months ago

Implement the resource for east-west VPC security policy.

ksamoray commented 2 months ago

/test-all

ksamoray commented 2 months ago

/test-all

ksamoray commented 2 months ago

/test-all

ksamoray commented 1 month ago

/test-all

ksamoray commented 1 month ago

/test-all

annakhm commented 1 month ago

This PR does not cover the provider-defined VPC scope yet, correct?

ksamoray commented 1 month ago

This PR does not cover the provider-defined VPC scope yet, correct?

Indeed - the provider-level VPC specification is a global, non per-resource change.

ksamoray commented 1 month ago

/test-all

qiyueyao commented 1 month ago

Hi, a quick maybe dumb question: does this series of change support data_source_nsxt_policy_security_policy and data_source_nsxt_policy_gateway_policy? Looks like for Get with ID, it's handled, but without ID, it still lists the domain 🤔

ksamoray commented 1 month ago

Hi, a quick maybe dumb question: does this series of change support data_source_nsxt_policy_security_policy and data_source_nsxt_policy_gateway_policy? Looks like for Get with ID, it's handled, but without ID, it still lists the domain 🤔

@qiyueyao I haven't got to handle these data sources yet but yeah - unless they use search API, they'll be affected by this change as the API wrapper is modified. I believe that I should add a check to the DS, that the VPC is not specified - as these datasources aren't supposed to serve VPC. VPC should have a pair of data_source_nsxt_policy_vpc.* datasources.

ksamoray commented 1 month ago

/test-all

ksamoray commented 1 month ago

/test-all

annakhm commented 1 month ago

LGTM. There are some doc fixes needed, but feel free to address them in one of the following PRs if you prefer

ksamoray commented 1 month ago

/test-all