search

vmware / terraform-provider-nsxt

Terraform VMware NSX-T provider
https://www.terraform.io/docs/providers/nsxt/
Other
123 stars 80 forks source link

Ignore display name for policy_ldap_identity_source when NSX version >= 4.2.1 #1241

Closed 2ez4szliu closed 1 week ago

2ez4szliu commented 4 weeks ago

Fix an issue with NSX version >= 4.2.1 that ldap_identity_source without display_name cannot be successfully created because NSX has forced the display_name to match its ID.

annakhm commented 3 weeks ago

Hi @2ez4szliu, can you please explain in more detail what NSX behavior we're trying to work around here?

2ez4szliu commented 3 weeks ago

Hi @2ez4szliu, can you please explain in more detail what NSX behavior we're trying to work around here?

Hi @annakhm, the issue is 3403819, if I understand correctly, before 421 we can specify arbitrary display_name for ldap_identity_source, but since 421 it has to match a specific value. As @salv-orlando suggested we can just ignore parsing display name on provider side, in that case the NSX resource created will use the correct name by default

ksamoray commented 3 weeks ago

As 4.2.1 isn't released yet, can't it be resolved within the platform?

ksamoray commented 3 weeks ago

/test-all

annakhm commented 3 weeks ago

I think its preferrable to remove display name from the resource (it is still in Beta)

annakhm commented 2 weeks ago

Suggested alternative https://github.com/vmware/terraform-provider-nsxt/pull/1254

salv-orlando commented 1 week ago

Closing this PR as it is superseded by PR #1254. Thanks a lot @2ez4szliu for your contribution!