Closed BergCyrill closed 3 weeks ago
@BergCyrill, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org>
to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.
All commits are signed & signoff was made according to the dco. I don't unterstand why the vmwclabot doesn't recognize this, I think it is a false behaviour.
/test-all
@BergCyrill sometimes the CLA bot also complains about my commits, when the email I specify in Signed-Off-By is not my primary github email. Not sure if this your case as well.
In any case I'm reviewing the CVE. I don't have any concern in addressing it of course, I just wonder why it did not get automatically flagged.
Thank you. My signoff mail is also my primary mail, so I really don't know what could be the issue.
Hi @BergCyrill, can you set version to 1.22? Seems like minor version is rejected by testing tools.
@BergCyrill, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org>
to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.
I have removed the patch version from the "go" line and set a toolchain version - hope the test tools do work properly now
I have removed the patch version from the "go" line and set a toolchain version - hope the test tools do work properly now
I've reran the CI, seems that it doesn't work yet :/
@BergCyrill, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org>
to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.
I have removed the reference to the patch version completely now.
@BergCyrill, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org>
to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.
Nice catch - thank you. I have increased the used go version in both of the test actions now.
Ok I think I have to bump golang-cilint to 1.56.1 to support go1.22
@BergCyrill, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org>
to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.
/test-all
/test-all
/test-all
Thanks @BergCyrill
Thanks @ksamoray Do you know when the next (patch-)release is planned?
Thanks @ksamoray Do you know when the next (patch-)release is planned?
General release schedule is published under milestones but we could have an earlier bugfix release.
Thanks @ksamoray Do you know when the next (patch-)release is planned?
General release schedule is published under milestones but we could have an earlier bugfix release.
Since it's a 9.8 critical severity issue and the next release is almost one month away a bugfix release would be really helpful. Thank you
Due to CVE-2024-24790 the used go version has to be pushed to 1.22.6