vmware / terraform-provider-nsxt

Terraform Provider for VMware NSX
https://registry.terraform.io/providers/vmware/nsxt/
Mozilla Public License 2.0
133 stars 85 forks source link

nsxt_firewall_section should support IPAddress for destination and source #491

Closed zenium closed 2 years ago

zenium commented 4 years ago

like in https://github.com/vmware/terraform-provider-nsxt/blob/master/nsxt/resource_nsxt_firewall_section.go#L104

"destination": getResourceReferencesSetSchema(false, false, []string{"IPSet", "LogicalPort", "LogicalSwitch", "NSGroup", "MACSet"}, "List of the destinations. Null will be treated as any"),

and

"source": getResourceReferencesSetSchema(false, false, []string{"IPSet", "LogicalPort", "LogicalSwitch", "NSGroup", "MACSet"}, "List of sources. Null will be treated as any"),

IPAddress should be included since NSX-T supports the IPAddress type here.

I've modified locally and tested, it works.

github-actions[bot] commented 3 years ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!