nsxt_policy_segment - advanced config - address_pool_path seems to be incorrect

burnsjared0415 commented 2 years ago

Describe the bug

When running resource "nsxt_policy_segment" and trying to add ip pool to segment, pool never gets added. Ran Postmon for the value and key and realized it is not address_pool_path in NSX-T 3.2.1, it seems to be address_pool_paths instead. Need to get this updated.

Reproduction steps

1.Try and create a segment with IP Pool assignment
2.Run API call policy/api/v1/infra/segments/ to see that the key is different
3.
...

Expected behavior

Add the IP pool to the Segment

Additional context

No response

annakhm commented 2 years ago

Hello @burnsjared0415, the provider supports single pool path as of now (while the platform supports multiple pools for different IP versions). Single pool is supposed to work. Could you please provide your configuration and logs, to show the problem in detail. Thank you!

burnsjared0415 commented 2 years ago

Create Segments with Static Address with IP Pool required configured

resource "nsxt_policy_segment" "segment_static_with_ip_pool" { display_name = var.segment_static_name_with_pool connectivity_path = data.nsxt_policy_tier1_gateway.tier1_gateway.path transport_zone_path = data.nsxt_policy_transport_zone.overlay_tz.path subnet { cidr = var.segment_static_name_with_pool_cidr } advanced_config { address_pool_path = data.nsxt_policy_ip_pool.ip_pool.path } }

if you look at the segment info here is what NSX-T wants: "advanced_config": { "address_pool_paths": [ "/infra/ip-pools/d7f4aaa5-18c9-440d-a5ec-9ac935adc925" ],

alagoutte commented 2 years ago

it is not only a typo and missing a s on https://github.com/vmware/terraform-provider-nsxt/blob/529889ac80c6b139369360167729e38eba06eeb2/nsxt/segment_common.go#L161

and also https://github.com/vmware/terraform-provider-nsxt/blob/529889ac80c6b139369360167729e38eba06eeb2/nsxt/segment_common.go#L1304

burnsjared0415 commented 2 years ago

So do i need to change my statements or is this a bug?

alagoutte commented 2 years ago

for me, it is a bug...

annakhm commented 2 years ago

Thank you for the details, confirmed its a bug. Fix coming soon.

annakhm commented 2 years ago

Just to be clear - we still support only one IP pool.

burnsjared0415 commented 2 years ago

Just need one because that is a nsx-t restriction

Get Outlook for iOShttps://aka.ms/o0ukef

From: annakhm @.> Sent: Wednesday, February 9, 2022 7:31:43 PM To: vmware/terraform-provider-nsxt @.> Cc: Jared Burns @.>; Mention @.> Subject: Re: [vmware/terraform-provider-nsxt] nsxt_policy_segment - advanced config - address_pool_path seems to be incorrect (Issue #707)

Just to be clear - we still support only one IP pool.

— Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvmware%2Fterraform-provider-nsxt%2Fissues%2F707%23issuecomment-1034354890&data=04%7C01%7Cburnsja%40vmware.com%7Cd80cab7cbde84beeef6f08d9ec2cb730%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637800499079897875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=OycR3pIRoxoIAPdvQc48oRADHqtFCddtuUtjfUgPaaw%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOU6LLDJ5BBB5OXLOQQ3NVDU2MBO7ANCNFSM5MNC2DCA&data=04%7C01%7Cburnsja%40vmware.com%7Cd80cab7cbde84beeef6f08d9ec2cb730%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637800499079897875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xaKDlNknG081iVYyaOg6t8AzOtBV%2FCyU0ECA4M3%2BDIk%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cburnsja%40vmware.com%7Cd80cab7cbde84beeef6f08d9ec2cb730%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637800499079897875%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=LYguXHQNWgPYC9bHaOKWT4PlK%2BB5xeEiBChnHWZmBI0%3D&reserved=0 or Androidhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cburnsja%40vmware.com%7Cd80cab7cbde84beeef6f08d9ec2cb730%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637800499080054117%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=2gGUY2fqur2Dej%2Bs4DRosMPOztm%2Bkr%2FMOv4hH6s9yAA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

burnsjared0415 commented 2 years ago

I test this morning and it does not look like the s was added to address_pool_paths

vmware / terraform-provider-nsxt