search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Secondary IP for AKS #304

Closed grenader closed 10 months ago

grenader commented 10 months ago
  1. What this PR does / why we need it: Add support for the 'Secondary IP' feature.

We have added:

The validations are:

  1. Which issue(s) this PR fixes (https://jira.eng.vmware.com/browse/TMC-43293)

  2. Additional information

In addition to the 'secondary IP' field validation, the "DNS Server Ip or service CIDR cannot be set is network plugin is 'kubenet'" restriction has been removed, to follow Azure's actual behavior.

vmwclabot commented 10 months ago

@grenader, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 10 months ago

@grenader, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (bc2a10e) 25.95% compared to head (145fb61) 25.54%. Report is 19 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #304 +/- ## ========================================== - Coverage 25.95% 25.54% -0.42% ========================================== Files 160 189 +29 Lines 14196 16013 +1817 ========================================== + Hits 3685 4090 +405 - Misses 10342 11717 +1375 - Partials 169 206 +37 ``` | [Files](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [internal/resources/akscluster/nodepool\_mapper.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvbm9kZXBvb2xfbWFwcGVyLmdv) | `85.71% <100.00%> (+0.23%)` | :arrow_up: | | [internal/resources/akscluster/schema.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvc2NoZW1hLmdv) | `86.95% <ø> (ø)` | | | [internal/resources/akscluster/akscluster\_mapper.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvYWtzY2x1c3Rlcl9tYXBwZXIuZ28=) | `82.17% <90.00%> (+0.20%)` | :arrow_up: | | [internal/helper/helper.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvaGVscGVyL2hlbHBlci5nbw==) | `30.93% <0.00%> (ø)` | | | [internal/resources/akscluster/resource\_nodepool.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvcmVzb3VyY2Vfbm9kZXBvb2wuZ28=) | `94.76% <95.52%> (-0.28%)` | :arrow_down: | | [...ternal/resources/akscluster/resource\_akscluster.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvcmVzb3VyY2VfYWtzY2x1c3Rlci5nbw==) | `85.44% <87.09%> (+0.83%)` | :arrow_up: | | [internal/resources/akscluster/data\_source.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Frc2NsdXN0ZXIvZGF0YV9zb3VyY2UuZ28=) | `17.91% <0.00%> (-8.76%)` | :arrow_down: | ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/304/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 10 months ago

@grenader, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.