search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Merging feature branch git CG k8s secret support #306

Closed Shubbhang351 closed 10 months ago

Shubbhang351 commented 10 months ago
  1. What this PR does / why we need it:

Merging feature branch git CG k8s secret support

Screenshot 2023-10-10 at 1 37 33 PM
Screenshot 2023-10-26 at 11 44 40 AM
codecov-commenter commented 10 months ago

Codecov Report

Attention: 548 lines in your changes are missing coverage. Please review.

Comparison is base (5e5cd0e) 25.62% compared to head (61aeffe) 25.36%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================== - Coverage 25.62% 25.36% -0.26% ========================================== Files 183 187 +4 Lines 15302 15621 +319 ========================================== + Hits 3921 3963 +42 - Misses 11184 11457 +273 - Partials 197 201 +4 ``` | [Files](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [internal/resources/kubernetessecret/test\_helper.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvdGVzdF9oZWxwZXIuZ28=) | `0.00% <ø> (ø)` | | | [...ces/kubernetessecret/status/cluster\_group\_scope.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc3RhdHVzL2NsdXN0ZXJfZ3JvdXBfc2NvcGUuZ28=) | `75.00% <75.00%> (ø)` | | | [internal/resources/kubernetessecret/spec/spec.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc3BlYy9zcGVjLmdv) | `0.00% <0.00%> (-30.44%)` | :arrow_down: | | [...resources/kubernetessecret/status/cluster\_scope.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc3RhdHVzL2NsdXN0ZXJfc2NvcGUuZ28=) | `52.63% <52.63%> (ø)` | | | [...urces/kubernetessecret/spec/cluster\_group\_scope.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc3BlYy9jbHVzdGVyX2dyb3VwX3Njb3BlLmdv) | `26.31% <26.31%> (ø)` | | | [.../resources/kubernetessecret/scope/cluster\_group.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc2NvcGUvY2x1c3Rlcl9ncm91cC5nbw==) | `37.50% <37.50%> (ø)` | | | [internal/resources/kubernetessecret/scope/scope.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc2NvcGUvc2NvcGUuZ28=) | `40.00% <44.82%> (+21.66%)` | :arrow_up: | | [...ternal/resources/kubernetessecret/scope/cluster.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc2NvcGUvY2x1c3Rlci5nbw==) | `34.37% <34.37%> (ø)` | | | [...l/resources/kubernetessecret/spec/cluster\_scope.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvc3BlYy9jbHVzdGVyX3Njb3BlLmdv) | `30.43% <30.43%> (ø)` | | | [...l/resources/kubernetessecret/data\_source\_secret.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2t1YmVybmV0ZXNzZWNyZXQvZGF0YV9zb3VyY2Vfc2VjcmV0Lmdv) | `0.00% <0.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/306/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ishangupta-ds commented 10 months ago

@Shubbhang351 the test failures are expected?

Shubbhang351 commented 10 months ago

@Shubbhang351 the test failures are expected?

Updated the latests tests snapshot.