search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Feat/Custom Policy Template -- Tests & Docs #322

Closed GilTeraSky closed 10 months ago

GilTeraSky commented 10 months ago

  1. What this PR does / why we need it: This PR includes the tests and docs for the custom policy template.

  2. Which issue(s) this PR fixes

  3. Additional information

  4. Special notes for your reviewer

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a89d0f) 25.58% compared to head (8324cd1) 25.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/custom-policy-template #322 +/- ## ============================================================ Coverage 25.58% 25.58% ============================================================ Files 187 187 Lines 15730 15730 ============================================================ Hits 4024 4024 Misses 11505 11505 Partials 201 201 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GilTeraSky commented 10 months ago

Does this MR needs to rebase? I saw duplicate + IAM policy related changes.

Each branch has its own piece of code, therefore you see that I also changed things in this branch that involved the naming convention. Regardless, every branch in the chain needs a rebase technically because they all go to the same intermediate branch but not all are branched initially from the intermediate branch since this is how we agreed to do when started the project.