search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

add ability to update default node pool for tkg #328

Closed warroyo closed 10 months ago

warroyo commented 10 months ago
  1. What this PR does / why we need it:

This adds the logic needed to be able to update certain settings on the default node pool through the cluster resource for TKGs and TKGm. This is not for cluster class based clusters.

vmwclabot commented 10 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (8c92a64) 25.72% compared to head (39a4e9e) 25.59%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #328 +/- ## ========================================== - Coverage 25.72% 25.59% -0.13% ========================================== Files 187 187 Lines 15780 15858 +78 ========================================== Hits 4059 4059 - Misses 11516 11594 +78 Partials 205 205 ``` | [Files](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [...ternal/resources/ekscluster/resource\_ekscluster.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Vrc2NsdXN0ZXIvcmVzb3VyY2VfZWtzY2x1c3Rlci5nbw==) | `16.74% <0.00%> (ø)` | | | [internal/resources/ekscluster/data\_source.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2Vrc2NsdXN0ZXIvZGF0YV9zb3VyY2UuZ28=) | `0.00% <0.00%> (ø)` | | | [internal/resources/cluster/resource\_cluster.go](https://app.codecov.io/gh/vmware/terraform-provider-tanzu-mission-control/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-aW50ZXJuYWwvcmVzb3VyY2VzL2NsdXN0ZXIvcmVzb3VyY2VfY2x1c3Rlci5nbw==) | `3.08% <0.00%> (-0.72%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.