search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

[Feature] Management cluster registration CRUD implementation #329

Closed ghost closed 10 months ago

ghost commented 10 months ago

  1. What this PR does / why we need it: Management cluster registration CRUD implementation

  2. Which issue(s) this PR fixes

  3. Additional information Related task: TMC-34852

  4. Special notes for your reviewer

codecov-commenter commented 10 months ago

Codecov Report

Attention: 318 lines in your changes are missing coverage. Please review.

Comparison is base (40ce30b) 27.13% compared to head (619667b) 25.50%.

Files Patch % Lines
...luster/resource_management_cluster_registration.go 8.09% 227 Missing :warning:
...ster/datasource_management_cluster_registration.go 0.00% 91 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/management_cluster_registration #329 +/- ## =========================================================================== - Coverage 27.13% 25.50% -1.64% =========================================================================== Files 191 162 -29 Lines 16619 14536 -2083 =========================================================================== - Hits 4510 3707 -803 + Misses 11903 10660 -1243 + Partials 206 169 -37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shobha2626 commented 10 months ago

LGTM

shobha2626 commented 10 months ago

Please attach the acceptance test screenshots to the PR

ghost commented 10 months ago

Please attach the acceptance test screenshots to the PR

acceptance_test acc_1 acc_2 acc_3