search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

[Feature] Management cluster registration #330

Closed ghost closed 9 months ago

ghost commented 10 months ago
  1. What this PR does / why we need it: Management cluster registration implementation
  2. Which issue(s) this PR fixes
  3. Additional information Related task: TMC-34852
vmwclabot commented 10 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 318 lines in your changes are missing coverage. Please review.

Comparison is base (5611492) 25.57% compared to head (5700611) 25.17%.

Files Patch % Lines
...luster/resource_management_cluster_registration.go 8.09% 227 Missing :warning:
...ster/datasource_management_cluster_registration.go 0.00% 91 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #330 +/- ## ========================================== - Coverage 25.57% 25.17% -0.41% ========================================== Files 187 189 +2 Lines 15881 16221 +340 ========================================== + Hits 4061 4083 +22 - Misses 11615 11933 +318 Partials 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 10 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

shobha2626 commented 9 months ago

Please squash and change commits into meaningful commits

vmwclabot commented 9 months ago

@ekoop-terasky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.