vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Add support to create self provisioned storage Azure blob for Data protection and Azure AKS credential #331

Closed ramya-bangera closed 10 months ago

ramya-bangera commented 10 months ago
  1. What this PR does / why we need it: Add support to create self provisioned storage Azure blob for Data protection and Azure AKS credential

  2. Which issue(s) this PR fixes

    (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
    Fixes #
  3. Additional information Acceptance test log snippet

    bangerar@bangerarYMD6M credential % go test ./... -v -tags credential    
    === RUN   TestAcceptanceForClusterGroupDataSource
    data_source_credential_test.go:43: credential data source acceptance test complete!
    --- PASS: TestAcceptanceForClusterGroupDataSource (15.13s)
    === RUN   TestAcceptanceForCredentialResource
    resource_credential_test.go:67: credential resource acceptance test complete!
    --- PASS: TestAcceptanceForCredentialResource (35.61s)
    PASS
    ok      github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/credential        51.313s

Screenshot of credential created via TMC TF

Screenshot 2023-11-15 at 6 15 47 PM
  1. Special notes for your reviewer
codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b1bda65) 25.72% compared to head (726753d) 25.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #331 +/- ## ======================================= Coverage 25.72% 25.72% ======================================= Files 187 187 Lines 15779 15779 ======================================= Hits 4059 4059 Misses 11515 11515 Partials 205 205 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ankitsny commented 10 months ago

LGTM