Closed GilTeraSky closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
50bbbf8
) 25.29% compared to head (e83bed2
) 25.30%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for attaching the screenshot, is all the CRUD operation tested?
Overall. LGTM
Thanks for attaching the screenshot, is all the CRUD operation tested?
Yes
What this PR does / why we need it: This PR includes the complete implementation of a Custom IAM Role.
Which issue(s) this PR fixes
Additional information Acceptance test log:
bangerar@bangerarYMD6M tests % go test -v -tags=customiamrole === RUN TestAcceptanceCustomIAMRoleResource custom_iam_role_test.go:72: Custom IAM role resource acceptance test complete! --- PASS: TestAcceptanceCustomIAMRoleResource (19.49s) PASS ok github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/customiamrole/tests 20.055s
Example custom role: