vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

[Feature complete]Custom IAM Role models, client, schema, implementation and docs #333

Closed GilTeraSky closed 7 months ago

GilTeraSky commented 10 months ago
  1. What this PR does / why we need it: This PR includes the complete implementation of a Custom IAM Role.

  2. Which issue(s) this PR fixes

  3. Additional information Acceptance test log: bangerar@bangerarYMD6M tests % go test -v -tags=customiamrole === RUN TestAcceptanceCustomIAMRoleResource custom_iam_role_test.go:72: Custom IAM role resource acceptance test complete! --- PASS: TestAcceptanceCustomIAMRoleResource (19.49s) PASS ok github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/customiamrole/tests 20.055s

Example custom role: Screenshot 2024-01-16 at 4 55 21 PM

  1. Special notes for your reviewer
codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (50bbbf8) 25.29% compared to head (e83bed2) 25.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #333 +/- ## ======================================= Coverage 25.29% 25.30% ======================================= Files 192 192 Lines 16657 16658 +1 ======================================= + Hits 4214 4215 +1 Misses 12225 12225 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shobha2626 commented 7 months ago

Thanks for attaching the screenshot, is all the CRUD operation tested?

shobha2626 commented 7 months ago

Overall. LGTM

ramya-bangera commented 7 months ago

Thanks for attaching the screenshot, is all the CRUD operation tested?

Yes