search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Feat/Custom Policy Template -- Feature Complete #334

Closed GilTeraSky closed 8 months ago

GilTeraSky commented 10 months ago
  1. What this PR does / why we need it: This PR includes the complete implementation of a Custom Policy Template.

Screenshot 2024-01-10 at 11 42 59 AM

Screenshot 2024-01-10 at 11 54 10 AM

Screenshot 2024-01-10 at 11 54 20 AM

Screenshot 2024-01-10 at 11 54 29 AM

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a83d88) 25.10% compared to head (dab40e0) 25.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #334 +/- ## ======================================= Coverage 25.10% 25.10% ======================================= Files 191 191 Lines 16482 16483 +1 ======================================= + Hits 4137 4138 +1 Misses 12131 12131 Partials 214 214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shobha2626 commented 9 months ago

@GilTeraSky can we please have a meaningful commit message, this is required because it is helpful while auto generation the release notes

shobha2626 commented 8 months ago

Validated the tests and CRUD operation through terraform script

shobha2626 commented 8 months ago

Any reason why we are not appending on docs/guides/tanzu-mission-control_policy.md as part of PR? I think we should illustrate custom policy template creation and then usage of said custom policy template as part of custom policy in said guide.

@vmw-vjn this PR is for custom policy template resource alone. it is consumed by custom policy assignment resource, implemented in PR here.

Will add the guide doc as part of the acceptance test PR for custom policy assignment.