Closed ghost closed 11 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
efa7cb8
) 25.50% compared to head (83ed771
) 25.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please attach a screenshot of successful mock test run
Please attach a screenshot of successful mock test run
Original:
Commented out kubeconfig acceptance test case to have explicit green result:
Please attach a screenshot of successful mock test run
Original:
Commented out kubeconfig acceptance test case to have explicit green result:
Passing a dummy kubeconfig should pass as we are mocking the API’s?
Please attach a screenshot of successful mock test run
Original: Commented out kubeconfig acceptance test case to have explicit green result:
Passing a dummy kubeconfig should pass as we are mocking the API’s?
No, I didn't see point mocking k8s client. This would mean creating mock responses to lot of layers. I checked that other resources haven't mock k8s client either.
What this PR does / why we need it: Management cluster registration mock tests
Which issue(s) this PR fixes
Additional information Related task: TMC-34852
Special notes for your reviewer