vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
37 stars 31 forks source link

[Feature] Management cluster registration mock tests #337

Closed ghost closed 11 months ago

ghost commented 11 months ago
  1. What this PR does / why we need it: Management cluster registration mock tests

  2. Which issue(s) this PR fixes

  3. Additional information Related task: TMC-34852

  4. Special notes for your reviewer

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (efa7cb8) 25.50% compared to head (83ed771) 25.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/management_cluster_registration #337 +/- ## ======================================================================== Coverage 25.50% 25.50% ======================================================================== Files 162 162 Lines 14536 14536 ======================================================================== Hits 3707 3707 Misses 10660 10660 Partials 169 169 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shobha2626 commented 11 months ago

Please attach a screenshot of successful mock test run

ghost commented 11 months ago

Please attach a screenshot of successful mock test run

Original: original

Commented out kubeconfig acceptance test case to have explicit green result: commented_out

shobha2626 commented 11 months ago

Please attach a screenshot of successful mock test run

Original: original

Commented out kubeconfig acceptance test case to have explicit green result: commented_out

Passing a dummy kubeconfig should pass as we are mocking the API’s?

ghost commented 11 months ago

Please attach a screenshot of successful mock test run

Original: original Commented out kubeconfig acceptance test case to have explicit green result: commented_out

Passing a dummy kubeconfig should pass as we are mocking the API’s?

No, I didn't see point mocking k8s client. This would mean creating mock responses to lot of layers. I checked that other resources haven't mock k8s client either.