search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Feat/Permission Template -- Feature Complete #342

Closed GilTeraSky closed 7 months ago

GilTeraSky commented 9 months ago

  1. What this PR does / why we need it: This PR includes the complete implementation of a Permission Template.

  2. Which issue(s) this PR fixes

  3. Additional information It was decided to go with a data source because there is no real state for a permission template as it can be generated for a non-existing credentials.

    The following issues were addressed as follows: a. When generating a permission template for EKS, the templateValue field might contains values which are not defined as parameters in the CloudFormation template. The workaround which was applied is to decode the template, and remove the undefined values. This values are being kept instead in another computed field "undefined_template_values". b. The CloudFormation template returned from the API defined only a "Message" field as output and which contains text and the ARN. The workaround should be implemented in the Terraform code to split the message data and get the ARN only.

  4. Special notes for your reviewer

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (50bbbf8) 25.29% compared to head (03d7e88) 25.30%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #342 +/- ## ======================================= Coverage 25.29% 25.30% ======================================= Files 192 192 Lines 16657 16659 +2 ======================================= + Hits 4214 4216 +2 Misses 12225 12225 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shobha2626 commented 9 months ago

@vmw-vjn having a guide section for permission template would be helpful?

shobha2626 commented 9 months ago

Please squash the commits accordingly

GilTeraSky commented 9 months ago

@vmw-vjn having a guide section for permission template would be helpful?

I included the entire Terraform config that utilizes the permission template, from my understanding a guide is needed when you need to create assets manually. In this case it is very simple, you have a data source with certain fields to be used in another resource, therefore it is very straight forwards to implement, especially when you can see the entire Terraform.

vmwclabot commented 8 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 8 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 8 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@GilTeraSky, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.