search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Feat/Custom Policy Assignment -- Feature Complete #347

Closed GilTeraSky closed 7 months ago

GilTeraSky commented 9 months ago

  1. What this PR does / why we need it: This PR includes the complete implementation of a Custom Policy Assignment.

  2. Which issue(s) this PR fixes

  3. Additional information a. It was needed to modify the InputData struct to support custom policy with custom template. b. Parameters field is a string because it is a dynamic field, therefore it will be populate with JSON encoded string for the parameters. c. On plan phase, parameters will be validated according to the OpenAPIV3 Schema that is defined for the custom template.

  4. Special notes for your reviewer

shobha2626 commented 9 months ago

Please squash the commits into meaningful commit message

codecov-commenter commented 9 months ago

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (d0d6414) 25.25% compared to head (013cd5d) 25.29%.

Files Patch % Lines
...ces/policy/kind/custom/recipe/tmc_custom_schema.go 41.05% 56 Missing :warning:
...ernal/resources/policy/kind/custom/input_schema.go 0.00% 31 Missing :warning:
...ternal/resources/policy/kind/custom/spec_schema.go 0.00% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #347 +/- ## ========================================== + Coverage 25.25% 25.29% +0.04% ========================================== Files 191 192 +1 Lines 16532 16657 +125 ========================================== + Hits 4175 4214 +39 - Misses 12139 12225 +86 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ramya-bangera commented 8 months ago

@shobha2626 - I could not find the acceptance tests , is it part of separate PR?

shobha2626 commented 8 months ago

@shobha2626 - I could not find the acceptance tests , is it part of separate PR?

@ramya-bangera acceptance test was not done as part of this PR. Will be opening a new PR with acceptance test changes

shobha2626 commented 7 months ago

Added acceptance test as part of the PR - https://github.com/vmware/terraform-provider-tanzu-mission-control/pull/371