search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Support cluster group scope for dataprotection resource #352

Closed rnarenpujari closed 8 months ago

rnarenpujari commented 9 months ago
  1. What this PR does / why we need it:

TMC now allows enabling data protection at the cluster group level. This PR adds this support to the existing dataprotection resource.

  1. Which issue(s) this PR fixes

    NA

  2. Additional information

Screenshot 2023-12-12 at 3 50 14 PM

  1. Special notes for your reviewer

Acceptance test passing (make acc-test with the dataprotection tag):

Screenshot 2024-01-08 at 5 06 25 PM

LMK if smaller PRs are preferred.

vmwclabot commented 9 months ago

@rnarenpujari, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@rnarenpujari, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ac75a1) 25.28% compared to head (d9c8894) 25.28%. Report is 2 commits behind head on feat/dataprotection-clustergroup.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/dataprotection-clustergroup #352 +/- ## ================================================================= Coverage 25.28% 25.28% ================================================================= Files 189 189 Lines 16345 16345 ================================================================= Hits 4133 4133 Misses 11998 11998 Partials 214 214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rnarenpujari commented 9 months ago

As part of this change only enabling DP at the cluster group level is included?

@ramya-bangera all CRUD operations for the dataprotection resource have been extended for cluster group scope in this PR. @eastaga is working on the backupschedule resource.

ramya-bangera commented 8 months ago

@rnarenpujari can you also attach the screenshot of acceptance test run?

vmwclabot commented 8 months ago

@rnarenpujari, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

rnarenpujari commented 8 months ago

@rnarenpujari can you also attach the screenshot of acceptance test run?

Done. PTAL.

rnarenpujari commented 8 months ago

TFTR!