search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true #353

Closed sreenivasmrpivot closed 7 months ago

sreenivasmrpivot commented 9 months ago

  1. What this PR does / why we need it: EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true

  2. Which issue(s) this PR fixes

    (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):

Fixes # TMC-43744

  3. Additional information

  4. Special notes for your reviewer

vmwclabot commented 9 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (4ac75a1) 25.28% compared to head (c947580) 25.28%. Report is 4 commits behind head on main.

Files Patch % Lines
internal/resources/ekscluster/data_source.go 16.66% 40 Missing :warning:
...ternal/resources/ekscluster/resource_ekscluster.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #353 +/- ## ======================================= Coverage 25.28% 25.28% ======================================= Files 189 189 Lines 16345 16399 +54 ======================================= + Hits 4133 4147 +14 - Misses 11998 12038 +40 Partials 214 214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 9 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 9 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 8 months ago

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.