search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Support Cluster Group Backup Schedule #358

Closed eastaga closed 7 months ago

eastaga commented 8 months ago
  1. What this PR does / why we need it:

To add support for CG DP Backup Schedule.

  1. Which issue(s) this PR fixes

  2. Additional information

    image image

  3. Special notes for your reviewer

vmwclabot commented 8 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (6ad9e9d) 25.09% compared to head (a3fc06b) 25.20%.

Files Patch % Lines
internal/resources/backupschedule/scope/scope.go 0.00% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/dataprotection-clustergroup #358 +/- ## ==================================================================== + Coverage 25.09% 25.20% +0.11% ==================================================================== Files 191 194 +3 Lines 16480 16542 +62 ==================================================================== + Hits 4135 4169 +34 - Misses 12131 12159 +28 Partials 214 214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 8 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

eastaga commented 7 months ago
image image
vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

rnarenpujari commented 7 months ago

I just merged my PR and that caused a few conflicts here. @eastaga LMK if you want me to resolve them.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.