vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Add support for aks managed identities #359

Closed gshaw-pivotal closed 7 months ago

gshaw-pivotal commented 8 months ago
  1. What this PR does / why we need it:

Support managed identities specification when creating and updating AKS clusters

  1. Which issue(s) this PR fixes

N/A

  1. Additional information

When using terraform apply a user can provide a identity_config section within the cluster config section of the terraform plan file. Here they can specify whether a system or user assigned managed identity is to be used for the cluster.

The default if an identity_config is not provide will be use a system assigned managed identity.

  1. Special notes for your reviewer

Changes were tested by creating and modifying clusters on Olympus dev stack. Scenarios tested are summarized below:

Terraform test - User assigned identity with empty struct Terraform test - User assigned identity with empty struct

Terraform test - User assigned identity with invalid identity Terraform test - User assigned identity with invalid identity

vmwclabot commented 8 months ago

@gshaw-pivotal, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8c08715) 25.09% compared to head (92c4692) 25.24%.

Files Patch % Lines
internal/resources/akscluster/akscluster_mapper.go 75.51% 8 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #359 +/- ## ========================================== + Coverage 25.09% 25.24% +0.14% ========================================== Files 191 191 Lines 16480 16529 +49 ========================================== + Hits 4135 4172 +37 - Misses 12131 12139 +8 - Partials 214 218 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 7 months ago

@gshaw-pivotal, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.