vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Feat/dataprotection clustergroup #375

Closed eastaga closed 6 months ago

eastaga commented 7 months ago
  1. What this PR does / why we need it: CG Data Protection and Backup Schedule

  2. Which issue(s) this PR fixes

    (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
    Fixes #
  3. Additional information

  4. Special notes for your reviewer

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 7 months ago

@eastaga, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

eastaga commented 7 months ago
image image image image image
codecov-commenter commented 6 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (88ddf24) 25.29% compared to head (312af6e) 25.40%.

Files Patch % Lines
internal/resources/backupschedule/scope/scope.go 0.00% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #375 +/- ## ========================================== + Coverage 25.29% 25.40% +0.10% ========================================== Files 192 195 +3 Lines 16722 16784 +62 ========================================== + Hits 4230 4264 +34 - Misses 12274 12302 +28 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ramya-bangera commented 6 months ago

Just glanced through the PR assuming it is end to end validated in the feature branch before seeking merge to main.