search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Implement fix for failing AKS acceptance/mock test #377

Closed gshaw-pivotal closed 6 months ago

gshaw-pivotal commented 6 months ago
  1. What this PR does / why we need it:

Fixes an AKS acceptance/mock test that was broken when managed identity work was introduced.

  1. Which issue(s) this PR fixes

As described above, the 'TestAccAksCluster_basics' test was broken by the introduction of supporting managed identities for AKS clusters. This MR fixes said failing test.

  1. Additional information

Tested both against a mock and real stack (by setting 'ENABLE_AKS_ENV_TEST' env variable).

  1. Special notes for your reviewer
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cb65605) 25.40% compared to head (9be22e2) 25.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #377 +/- ## ======================================= Coverage 25.40% 25.40% ======================================= Files 195 195 Lines 16784 16784 ======================================= Hits 4264 4264 Misses 12302 12302 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.