search

vmware / terraform-provider-tanzu-mission-control

Terraform provider to manage resources of Tanzu Mission Control
Mozilla Public License 2.0
38 stars 31 forks source link

Fix Provisioner List Data read #379

Closed shobha2626 closed 6 months ago

shobha2626 commented 6 months ago

  1. What this PR does / why we need it: Fix Provisioner List Data read

  2. Which issue(s) this PR fixes

Data source acceptance test

image

{ "version": 4, "terraform_version": "1.6.4", "serial": 2, "lineage": "0b6f3483-1df4-bc67-fa8e-0263fed0b3f9", "outputs": {}, "resources": [ { "mode": "data", "type": "tanzu-mission-control_provisioner", "name": "read_provisioner", "provider": "provider[\"vmware/devtest/tanzu-mission-control\"]", "instances": [ { "schema_version": 0, "attributes": { "id": "prvn:01HP45HJY9NJTTRB69BH1PZ49S", "provisioners": [ { "management_cluster": "eks", "meta": [], "name": "demo-test", "org_id": "" } ] }, "sensitive_attributes": [] } ] } ], "check_results": null }

// LIST of Provisioners

"provisioners": [ { "management_cluster": "eks", "meta": [], "name": "tf-test", "org_id": "" }, { "management_cluster": "eks", "meta": [], "name": "tf-prv-test-2322938641799613315", "org_id": "" }, { "management_cluster": "eks", "meta": [], "name": "tf-prv-test-9059343843537634380", "org_id": "" }, { "management_cluster": "eks", "meta": [], "name": "tf-prv-test-2312083577691511843", "org_id": "" },

  1. Additional information

  2. Special notes for your reviewer

codecov-commenter commented 6 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (95cef99) 25.39% compared to head (2edb61c) 25.36%.

Files Patch % Lines
...l/resources/provisioner/data_source_provisioner.go 0.00% 36 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ========================================== - Coverage 25.39% 25.36% -0.04% ========================================== Files 195 195 Lines 16788 16810 +22 ========================================== Hits 4264 4264 - Misses 12306 12328 +22 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmwclabot commented 6 months ago

@shobha2626, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.