Closed shobha2626 closed 6 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
aa47e00
) 25.36% compared to head (c178b75
) 25.36%.
Files | Patch % | Lines |
---|---|---|
internal/resources/common/objectmeta_schema.go | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@shobha2626 - Does the state file dump given in description captures the state file info with LIST or GET datasource? If it's just GET can you add the LIST too? As there are changes to common meta converter code have you validated the automation against your change?
@shobha2626 - Does the state file dump given in description captures the state file info with LIST or GET datasource? If it's just GET can you add the LIST too? As there are changes to common meta converter code have you validated the automation against your change?
@ramya-bangera I have captured only GET because the result for LIST is huge. I have verified the LIST as well, if needed I can run again and share the same. I have validate this change against other resource like namespace and workspace manually and there seems to be no issue. It is optional parameter and shouldn't cause any.
@shobha2626 - Does the state file dump given in description captures the state file info with LIST or GET datasource? If it's just GET can you add the LIST too? As there are changes to common meta converter code have you validated the automation against your change?
@ramya-bangera I have captured only GET because the result for LIST is huge. I have verified the LIST as well, if needed I can run again and share the same. I have validate this change against other resource like namespace and workspace manually and there seems to be no issue. It is optional parameter and shouldn't cause any.
Thanks for confirming , since these details was missing I just wanted to be sure that it is validated.
Make meta data converter mapping generic and populate provisioner meta info
Meta converter was not supporting the array format as that of a provisioner resource. As a result, meta was not getting populated for provisioner because the model path was not including the entire path. In Provisioner resource scenario the meta should be
provisioner.meta
.Made changes to accomodate this change not just for provisioner but any resource that follows this structure
{ "version": 4, "terraform_version": "1.6.4", "serial": 1, "lineage": "2dcd02f2-3dcc-d8a3-42b1-f05b03f9e9fe", "outputs": {}, "resources": [ { "mode": "data", "type": "tanzu-mission-control_provisioner", "name": "read_provisioner", "provider": "provider[\"vmware/devd/tanzu-mission-control\"]", "instances": [ { "schema_version": 0, "attributes": { "id": "prvn:01HQ2DV4SAY0C5G832WHZ4TBST", "provisioners": [ { "management_cluster": "eks", "meta": [ { "annotations": {}, "description": "Create provisioner through terraform", "labels": { "key1": "value1", "key2": "value2" }, "resource_version": "4965", "uid": "prvn:01HQ2DV4SAY0C5G832WHZ4TBST" } ], "name": "mshobha-test", "org_id": "" } ] }, "sensitive_attributes": [] } ] } ], "check_results": null }
Additional information
Special notes for your reviewer