Add opaque secret type - Githubissues

warroyo commented 5 months ago

What this PR does / why we need it: This adds the ability to use opaque secret type with the k8s secret resource

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 4a303a962c0591a14743671087b557cb386d756a must be signed by warroyo7199008@gmail.com

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 4a303a962c0591a14743671087b557cb386d756a must be signed by warroyo7199008@gmail.com

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 18.26923% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 25.23%. Comparing base (102b2ad) to head (d5171ca). Report is 2 commits behind head on main.

Files	Patch %	Lines
internal/resources/kubernetessecret/spec/spec.go	0.00%	35 Missing :warning:
...l/resources/kubernetessecret/spec/cluster_scope.go	41.46%	21 Missing and 3 partials :warning:
...rnal/resources/kubernetessecret/resource_secret.go	0.00%	18 Missing :warning:
...l/resources/kubernetessecret/data_source_secret.go	0.00%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #385 +/- ## ========================================== - Coverage 25.31% 25.23% -0.08% ========================================== Files 195 195 Lines 16845 16908 +63 ========================================== + Hits 4264 4267 +3 - Misses 12363 12423 +60 Partials 218 218 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vmw-vjn commented 5 months ago

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 260b55d664463605afd94650733d1912bb04037a must be signed by sakabarali@vmware.com

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit e19a536581db7613c5828f7c97dea7e53110e811 must be signed by sakabarali@vmware.com

shobha2626 commented 5 months ago

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

@vmw-vjn Documentation and acceptance changes are missing in the PR. We would need them before making the release with this change

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 18777e945712045550e759ecc832ed042b5eb0ee must be signed by sakabarali@vmware.com

AkbaraliShaikh commented 5 months ago

@AkbaraliShaikh - can you kindly review and add/append to this PR wrt TMC-56160

cc: @shobha2626 / @ramya-bangera

@warroyo I have fixed/updated the following in my commit

opaque update was not working - fixed
updated the documentation
fixed the lint errors

Can you please update the acceptance tests?

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit d731693ea490891aaf87e1d6e45ecc5b14417b64 must be signed by sakabarali@vmware.com

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 914780306c719eb2142ca6494fbb4602a6d1232c must be signed by sakabarali@vmware.com

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 914780306c719eb2142ca6494fbb4602a6d1232c must be signed by sakabarali@vmware.com

vmwclabot commented 5 months ago

@warroyo, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Commit 914780306c719eb2142ca6494fbb4602a6d1232c must be signed by sakabarali@vmware.com

AkbaraliShaikh commented 5 months ago

@AkbaraliShaikh / @warroyo could you pease share the screenshot of successful mock test and acceptance test screenshot?

vmware / terraform-provider-tanzu-mission-control

Add opaque secret type #385

Codecov Report