Closed spacegospod closed 9 months ago
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Summary of Pull Request
The upper limit that the SDDC manager enforces on ASN values is 2^32 (4294967295). In our code this is evaluated by raising 2 to the power of 32 and trying to cast it into the default integer. On systems where Golang's integer defaults to 32-bit signed this cannot be enforced since it will overflow and actually produce a negative value.
Even if we change the validation util to work with int64 the input values would theoretically overflow since Terraform's integer inputs use the default int type.
Type of Pull Request
Related to Existing Issues
Closes #120
Test and Documentation Coverage
For bug fixes or features:
Breaking Changes?