vmware / terraform-provider-vcf

Terraform Provider for VMware Cloud Foundation
https://registry.terraform.io/providers/vmware/vcf/
Mozilla Public License 2.0
22 stars 9 forks source link

feat: enable vum-based bringup via `r/vcf_instance` #189

Closed spacegospod closed 3 months ago

spacegospod commented 3 months ago

Summary of Pull Request

Enable VUM-based bringup via resource_vcf_instance.

I am adding a new property cluster_image_enabled which when set to false disables vLCM when deploying a management domain.

The default value inferred by the API for this property is true.

Type of Pull Request

Related to Existing Issues

Closes #151

Test and Documentation Coverage

Ran TestAccResourceVcfSddcBasic

I did a minor fix to the test that I forgot to submit along with the SDK upgrade. The secondary DNS can no longer match the primary DNS and the API fails in VCF 5.X

To resolve this I've simply removed the secondary DNS from the test since it's optional

For bug fixes or features:

Breaking Changes?

resource_vcf_instance will stop working for 4.x releases since the new property will not be available.