Closed spacegospod closed 3 months ago
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Summary of Pull Request
Support for configuring vSAN in ESA mode was added in VCF 5. It was implemented as an optional attribute with https://github.com/vmware/terraform-provider-vcf/pull/190
The flaw in my original PR is that the new property is optional and since it is marked with "omitempty" it is skipped during serialization whenever it is set to false.
I've made a change to the SDK that marks the property as required. The containing structure is still optional.
This means that
esa_enabled
will now behave as follows:esa_enabled = true
theVSANEsaConfig
structure will be set and vSAN will be configured in ESA modeesa_enabled = false
theVSANEsaConfig
structure will be set and vSAN will be configured in normal modeesa_enabled
is not set theVSANEsaConfig
structure will be set and vSAN will be configured in normal modeThis will ensure that
Type of Pull Request
Related to Existing Issues
Closes #217
Test and Documentation Coverage
Ran TestAccResourceVcfSddcBasic by modifying the configuration for the 3 scenarios listed above - esa_enabled set to true, false and to nothing.
For bug fixes or features:
Breaking Changes?