Improper Error message for missing SDDC info

pradeep17j commented 5 days ago

Code of Conduct

[X] I have read and agree to the Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[X] Do not leave "+1" or other comments that do not add relevant information or questions.
[X] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform

v1.7.2

Terraform Provider

0.9.1

VMware Cloud Foundation

v5.0

Description

When SDDC information is not provided while creating resource vcf_domain , the error message complains about missing Cloud builder information . The error message should have been about missing SDDC info

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Invalid provider configuration
│
│ Provider "registry.terraform.io/vmware/vcf" requires explicit configuration. Add a provider block to the root module and configure the provider's required arguments as described in the provider documentation.
│
╵
╷
│ Error: CloudBuilder username, password and host must be provided
│
│   with provider["registry.terraform.io/vmware/vcf"],
│   on <empty> line 0:
│   (source code not available)

Affected Resources or Data Sources

resource/vcf_domain

Terraform Configuration

provider.tf file without provider vcf{} block

Debug Output

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Invalid provider configuration
│
│ Provider "registry.terraform.io/vmware/vcf" requires explicit configuration. Add a provider block to the root module and configure the provider's required arguments as described in the provider documentation.
│
╵
╷
│ Error: CloudBuilder username, password and host must be provided
│
│   with provider["registry.terraform.io/vmware/vcf"],
│   on <empty> line 0:
│   (source code not available)

Panic Output

No response

Expected Behavior

Complains about missing Cloud builder information

Actual Behavior

Should have mentioned about missing SDDC manager information

Steps to Reproduce

terraform plan with out provider vcf { } block in provider.tf file

Environment Details

No response

Screenshots

No response

References

No response

tenthirtyam commented 5 days ago

Ah, this is an easy fix in the providerConfigure function where if the sddc manager username is not provided it's assume to be cloud builder. will need an else if and then an else with a generic provider credentials error.

tenthirtyam commented 4 days ago

Addressed in #239.

vmware / terraform-provider-vcf