fix: `validation_utils.IsEmpty` doesn't check for boolean values

[hedenface]

Signed-off-by: Bryan Heden b.heden@gmail.com

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

This offers a fix during vcf_domain creation when defining an nfs_datastore. The validation_utils.IsEmpty function doesn't check properly for a boolean value. This could also fix potential bugs in a few other places.

https://github.com/vmware/terraform-provider-vcf/blob/v0.2.0/internal/datastores/nfs_datastore_subresource.go#L68-L72

Type of Pull Request

• [x] This is a bug fix.
• [ ] This is an enhancement or feature.
• [ ] This is a code style/formatting update.
• [ ] This is a documentation update.
• [ ] This is a refactoring update.
• [ ] This is a chore update
• [ ] This is something else. Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

• [ ] Tests have been completed.
• [ ] Documentation has been added/updated.

Breaking Changes?

• [ ] Yes, there are breaking changes.
• [x] No, there are no breaking changes.

[hedenface]

@tenthirtyam This is the follow up to 45, appropriately signed.

[hedenface]

So, going through the codebase, it looks like this fix affects the bug I already listed in the description, but also probably the following locations:

• https://github.com/vmware/terraform-provider-vcf/blob/main/internal/datastores/vsan_datastore_subresource.go#L59-L61
• https://github.com/vmware/terraform-provider-vcf/blob/main/internal/network/vds_subresource.go#L63-L65

[dimitarproynov]

Thanks!

[dimitarproynov]

I'm struggling with some unexpected behavior in Acceptance E2E tests, but I'm planning a release right after the struggle is over.

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.