vmware / terraform-provider-vcf

Terraform Provider for VMware Cloud Foundation
https://registry.terraform.io/providers/vmware/vcf/
Mozilla Public License 2.0
23 stars 10 forks source link

fix: domain update and expand E2E #47

Closed dimitarproynov closed 1 year ago

dimitarproynov commented 1 year ago

Summary of Pull Request

The domain update logic failed to do a refresh (read) just after the update operation has completed. This resulted in failing acceptance test, the fix to which was simple: execute a read at the end of domain update method. Some function parameter order was messed up.

Additionally, the Domain E2E test was expanded with:

Add a second cluster, Add a forth host in the additional cluster, Remove the forth host, Remove the additional cluster

This way all update operations, currently supported for domain are tested.

Also optimise domain E2E test resource usage.

Type of Pull Request

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

Testing done: make lint make build make test

=== RUN TestAccResourceVcfDomain === PAUSE TestAccResourceVcfDomain === CONT TestAccResourceVcfDomain --- PASS: TestAccResourceVcfDomain (16852.67s) PASS

For bug fixes or features:

Breaking Changes?

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.