Add support for FQDN in ntp_servers

LifeOfBrianOC commented 1 year ago

Code of Conduct

[X] I have read and agree to the project's Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[ ] Do not leave "+1" or other comments that do not add relevant information or questions.
[ ] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Please consider adding support for FQDN in ntp_servers when creating a VCF instance. Currently, the provider is validating for IPAddress only "validation.IsIPAddress"

Use Case(s)

Many customers use FQDN for NTP servers, or a CNAME entry in DNS to round-robin multiple backing NTP servers

Potential Configuration

Add additional validation for FQDN

References

No response

tenthirtyam commented 1 year ago

Completely agree!

dimitarproynov commented 1 year ago

Fix is merged and will be out with the next version v0.6.0

LifeOfBrianOC commented 1 year ago

Awesome, thank you!

github-actions[bot] commented 11 months ago

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

vmware / terraform-provider-vcf