lease_expire_at null in tfstate, but date in webapi

azrdev commented 2 years ago

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:

[x] I have read and agree to the project's Code of Conduct

vRA Version

vRealize Automation 8.8.0.22148 (19691889)

Terraform Version

Terraform v1.1.9

vRA Terraform Provider Version

provider registry.terraform.io/vmware/vra v0.5.1

Affected Resource(s)

vra_deployment

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.

Expected Behavior

Our vRA imposes a lifetime on all deployments, i.e. they expire after 30 days. This is displayed in the web UI, and the browser console shows the displayed date comes in an API response from https://vra.example.com/deployment/api/deployments like

{
  "content": [
    {
      "name": "test",
      "leaseExpireAt": "2022-05-26T10:54:00Z",
      ...

However the terraform.tfstate contains among instance properties "lease_expire_at": null,.

Actual Behavior

Terraform knowing the expiration date (and better yet the expiration state -- the underlying issue is that our VMs are known to terraform as existing fine, although they are expired and thus inaccessible to users)

Steps to Reproduce

terraform import vra_deployment $UUID
grep expire terraform.tfstate

Screenshots

Debug Output

Important Factoids

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

azrdev commented 2 years ago

looks like the relevant code is at https://github.com/vmware/terraform-provider-vra/blob/690aa71fe1fb3a81a767cde0dc7a7c95ce589f04/vra/resource_deployment.go#L399 but to get further s/o with more go (and the auto-generated api client code) knowledge would be needed

azrdev commented 2 years ago

I'm frequently running into my VMs expiring and terraform still returning them just fine, requiring manual interaction. I believe fixing this issue would allow me to build a workaround (using replace_triggered_by), what would it take to fix it?

vmware / terraform-provider-vra